Allowing: Minimum Word Length & Frequencies of Numbers #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added self.min_word_length=0. Added conditional filter in WordCloud.process_text() for word length. When parameter set to positive integer, remove words that do not exceed the minimum word length.
amueller
reviewed
Jan 27, 2019
.vscode/settings.json
Outdated
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
can you please remove this file?
|
I would maybe not add two more examples as there already are quite a few. Can you maybe add one and also add tests for the two new options? Thanks! |
|
Will do a clean pull request again, with just one commit and remove the files. Sorry about that. |
|
You can also just change this one, with squash & merge it doesn't matter.
Sent from phone. Please excuse spelling and brevity.
…On Tue, Jan 29, 2019, 03:32 RCCG ***@***.*** wrote:
Will do a clean pull request again, with just one commit and remove the
files. Sorry about that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#465 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbcFuEpAyzpmNqwXomtdw6i72okUkD1ks5vIAcfgaJpZM4aUu9h>
.
|
… get removed in word_cloud. Fix to allow single letter inclusion in RegEx later.
|
looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameters to WordCloud() to allow for filtering frequencies of numbers, as well as filtering by minimum length of a word.
Numbers are useful for visualizing patterns in numbers, dummy example using random numbers and the first 10,000 digits of pi.
Minimum word length is a simple way for filtering out functional words in foreign languages without having to write stopword lists or use pre-defined functional word collections. Examples filters A New Hope with length rather than stopwords.
Note: obviously not the most efficient implementations, but kept these in line with the style of the rest of the package.