-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macos: Migrate to objc2-core-foundation
#96
Conversation
8954442
to
0c63319
Compare
Yeah, (I'll also link to discussion in #87 regarding supply-chain attacks, the concerns there are more pronounced when targetting macOS). |
@MarijnS95 unlike #87, it's less clear why this PR is useful/important to |
Sure, it's less obvious because unlike the iOS code For the time being this might not look like a win as no high(er)-level bindings are available and certain helpers had to be copied/inlined from It might be better to hold off merging this for a little bit, but it's hopefully useful for @madsmtm to inventorize how certain ecosystem crates might be using these Apple/objc bindings and from what improvements they could benefit the most. |
It is! Thanks! And I do think |
I would certainly like to move to
Given that I plan to revisit this in a few months time, by which time the nature of changes would likely expected to be different, I'm closing this PR. If you don't expect the code to be much different in a few months (except for the clean up of all the |
Pushing to this PR (to improve the unwraps and experiment with other changes) would mean it can no longer be reopened. And I cannot reopen it myself after it was closed by a maintainer for that purpose. |
I'm leaving it open in that case. |
0c63319
to
1690c6d
Compare
All tests succeed. Opening as draft because there are no helpers yet an all functions have to be called on a low level with no safety abstractions. Following up on #95 because I upgraded
objc2
dependencies for iOS but noticed we could just as well utilize the newobjc2
CF crate for MacOS now.The
objc2-core-servcies
crate is empty as of yet so all these external functions remain defined in-line.CC @madsmtm