Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tufte css theme #3077

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

DamonsJ
Copy link

@DamonsJ DamonsJ commented Mar 16, 2025

add tufte css theme
add sidenote and marginfigure

see alse :

https://github.com/edwardtufte/tufte-css

https://github.com/clayh53/tufte-jekyll

Copy link

netlify bot commented Mar 16, 2025

Deploy Preview for relaxed-lollipop-b6bc17 ready!

Name Link
🔨 Latest commit bc0bd2c
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-lollipop-b6bc17/deploys/67d69ed7a000d7000873c53f
😎 Deploy Preview https://deploy-preview-3077--relaxed-lollipop-b6bc17.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@george-gca
Copy link
Collaborator

Nice work porting the Jekyll solution. But I'll need more time to review this.

I think we should first understand why tufte-jekyll implemented a lot of stuff as plugins. Then we should check if we should do the same, or if there is a more elegant solution. Also idk if just importing the css file wouldn't clash with our current csses. Maybe it interferes with the current built-in posts or projects, then we should be more careful. Maybe we should create something like the solution we use for importing other libraries, like when doing plots, that we add some flag to the post front matter and that enables the importing of the css.

I'll take a deeper look at it, but it will take some time, since I have been busy with other stuff at hand.

@DamonsJ
Copy link
Author

DamonsJ commented Mar 17, 2025

If there is a better solution, that would be great.
take your time, but please consider the sidenote stuff!

@george-gca
Copy link
Collaborator

I agree that the side note is really useful, and it would be a great addition. I am just afraid that simply importing the css might override some classes and mess with the styling of the site somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants