Bug: org-ql-find + query-prefix lead to "Match Required" error on Vertico

[danielfleischer]

Run the following:

(org-ql-find (org-agenda-files) :query-prefix "heading:")

Get a list of completions, when trying to select something, you get "Match Required", can't complete the selection; using Vertico.

[alphapapa]

Hello Daniel,

Thanks for reporting this problem, but I am unable to reproduce that behavior in a clean Emacs configuration on Emacs 28.2. Please try to reproduce it in a clean configuration using https://github.com/alphapapa/with-emacs.sh.

Please see also other issues mentioning Vertico: https://github.com/alphapapa/org-ql/issues?q=is%3Aissue+is%3Aopen+vertico If what you're reporting is also reported in one of them, please close this report and add your feedback there.

Thanks.

[danielfleischer]

Hi, I was able to reproduce with

1. ./with-emacs.sh -O -- -L ~/Projects/org-mode/lisp/ -l org
2. Installing vertico, enabling it, installing org-ql.
3. Running (org-ql-find '("myfile.org") :query-prefix "heading:").
4. Trying to choose something, getting "Match Required" error.

Emacs master 30, org master, vertico 1.3.

However I'm able to fix it by changing

org-ql/org-ql-completing-read.el

Line 267 in 2c09854

(selected (completing-read prompt #'collection nil t)))

making the match-required nil:

             (selected (completing-read prompt #'collection nil nil)))

However I do realize this is a very complicated function, with many comments and not sure if this breaks something else.

[alphapapa]

Hi @danielfleischer (and cc: @staffordsbeard):

I confirmed the bug and have pushed a fix in this commit (the wip/351 branch): 95abce2 It seems to solve the problem, and org-ql-find seems to still work when used without the :query-prefix argument. Please test it and let me know if it works for you.

Thanks.

[danielfleischer]

Hi, I can confirm it's working as expected. Thanks!