fix(sol!)!: gen unit struct for no param events
#885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
changed the title
event): gen unit struct for no param eventsevent)!: gen unit struct for no param events
yash-atreya
changed the title
event)!: gen unit struct for no param eventssol!)!: gen unit struct for no param events
yash-atreya
requested review from
DaniPopes,
gakonst and
mattsse
as code owners
mattsse
approved these changes
Feb 21, 2025
| @@ -146,14 +146,24 @@ pub(super) fn expand(cx: &ExpCtxt<'_>, event: &ItemEvent) -> Result<TokenStream> | |||
|
|
|||
| let alloy_sol_types = &cx.crates.sol_types; | |||
|
|
|||
| let event_struct = if event.parameters.is_empty() { | |||
| quote! { | |||
| pub struct #name; | |||
There was a problem hiding this comment.
should we derive default in these cases?
This comment was marked as resolved.
This comment was marked as resolved.
DaniPopes
approved these changes
Mar 12, 2025
3 tasks
yash-atreya
added a commit
that referenced
this pull request
Mar 12, 2025
…0/1 param (#883) * feat(`sol!`)!: generate unit/tuple structs for errors with 0/1 param * fix * fix: expand as tuple struct only when param is unnamed * nit * FieldKind * fix * feat(`sol!`)!: gen unit/tuple structs for call types with 0/1 param (#884) * feat(`sol!`)!: gen unit/tuple structs for call types with 0/1 param * fix: expand as tuple struct only if single unnamed param * fix(`sol!`)!: gen unit struct for no param events (#885) * expand as unit struct if no params * nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #879
Stacked over #883
Solution
Bindings for events with params remain unchanged.
PR Checklist