Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize php generator #49

Merged
merged 1 commit into from
Sep 29, 2020
Merged

optimize php generator #49

merged 1 commit into from
Sep 29, 2020

Conversation

AxiosLeo
Copy link
Contributor

  1. Add debug.warning method
  2. Add emitter.fixed method
  3. Add test case

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2020

Codecov Report

Merging #49 into master will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   94.97%   95.38%   +0.40%     
==========================================
  Files          15       15              
  Lines        2231     2254      +23     
==========================================
+ Hits         2119     2150      +31     
+ Misses        112      104       -8     
Impacted Files Coverage Δ
src/generator.js 95.00% <100.00%> (+0.05%) ⬆️
src/lib/debug.js 100.00% <100.00%> (ø)
src/lib/emitter.js 100.00% <100.00%> (ø)
src/langs/php/package_info.js 85.71% <0.00%> (+16.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7704992...2d6abae. Read the comment docs.

1. Add debug.warning method
2. Add emitter.fixed method
3. Add test case
@yndu13 yndu13 merged commit 5855eda into aliyun:master Sep 29, 2020
@AxiosLeo AxiosLeo deleted the dev/20200929 branch September 29, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants