Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch php generator #17

Merged
merged 1 commit into from
Jul 13, 2020
Merged

patch php generator #17

merged 1 commit into from
Jul 13, 2020

Conversation

AxiosLeo
Copy link
Contributor

  1. Supported emit test files.
  2. Optimizing the ResolveImports method.
  3. Optimizing test case.
  4. Optimizing emit @throw comment.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2020

Codecov Report

Merging #17 into master will decrease coverage by 0.20%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   95.29%   95.09%   -0.21%     
==========================================
  Files          15       15              
  Lines        2041     2079      +38     
==========================================
+ Hits         1945     1977      +32     
- Misses         96      102       +6     
Impacted Files Coverage Δ
src/resolver/base.js 94.91% <ø> (+6.54%) ⬆️
src/langs/php/combinator.js 89.37% <43.33%> (-1.86%) ⬇️
src/langs/php/package_info.js 65.95% <55.55%> (-2.34%) ⬇️
src/generator.js 91.57% <100.00%> (+0.08%) ⬆️
src/langs/common/items.js 100.00% <100.00%> (ø)
src/resolver/client.js 100.00% <100.00%> (+0.55%) ⬆️
src/langs/common/combinator.js 100.00% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b0675...a80fe94. Read the comment docs.

1. Supported emit test files.
2. Optimizing the `ResolveImports` method.
3. Optimizing test case.
4. Optimizing emit @throw comment.
@peze peze merged commit 05d7f3e into aliyun:master Jul 13, 2020
@AxiosLeo AxiosLeo deleted the patch/20200713 branch July 13, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants