Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch php generator #16

Merged
merged 1 commit into from
Jul 13, 2020
Merged

patch php generator #16

merged 1 commit into from
Jul 13, 2020

Conversation

AxiosLeo
Copy link
Contributor

  1. Supported set default clientName.
  2. Discard strongly typed types in PHP code.
  3. Fix the problem code of exception.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2020

Codecov Report

Merging #16 into master will increase coverage by 0.07%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   95.21%   95.29%   +0.07%     
==========================================
  Files          15       15              
  Lines        2049     2041       -8     
==========================================
- Hits         1951     1945       -6     
+ Misses         98       96       -2     
Impacted Files Coverage Δ
src/langs/php/config.js 100.00% <ø> (ø)
src/generator.js 91.48% <66.66%> (+0.37%) ⬆️
src/langs/php/combinator.js 91.22% <87.50%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb405fc...d245677. Read the comment docs.

1. Supported set default clientName.
2. Discard strongly typed types in PHP code.
3. Fix the problem code of exception.
@peze peze merged commit 26b0675 into aliyun:master Jul 13, 2020
@AxiosLeo AxiosLeo deleted the patch/20200710 branch July 13, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants