Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall sudo password incorrect bug #6

Closed
alichtman opened this issue Mar 19, 2018 · 3 comments
Closed

Firewall sudo password incorrect bug #6

alichtman opened this issue Mar 19, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@alichtman
Copy link
Owner

image

Should skip all firewall options if sudo password not entered correctly.

Although, maybe just leave this as-is because they'll be prompted for the pass again when the reset socketfilterfw command is run and they won't have the pass then either. No password, no changes. So no problem?

@alichtman alichtman added the bug Something isn't working label Mar 19, 2018
@alichtman alichtman reopened this Mar 20, 2018
@alichtman
Copy link
Owner Author

Low-priority, but should be try-excepted. Display FIREWALL CONFIG ERROR in red and do not display rest of firewall options if the sudo password is not accepted.

@alichtman
Copy link
Owner Author

alichtman commented Mar 24, 2018

The real issue here is that I don't know if enabling logging will also enable the firewall, so people may exit this program thinking they enabled the firewall but didn't.

I need some way to see if the first sudo command executed correctly to decide whether or not to show the rest of the firewall options.

@alichtman alichtman changed the title Y for firewall, incorrect sudo password entered bug Firewall sudo password incorrect bug Mar 24, 2018
@alichtman alichtman mentioned this issue Apr 5, 2018
@alichtman alichtman reopened this Apr 6, 2018
@alichtman
Copy link
Owner Author

lmao I thought I fixed this

alichtman added a commit that referenced this issue Apr 6, 2018
Added print abort

sudo password prompt at beginning to fix #6

Stylized restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant