Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: atag input value in iOS #976

Merged
merged 2 commits into from
Mar 13, 2019
Merged

fix: atag input value in iOS #976

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c267b3c
fix: atag input value in iOS
wssgcg1213 Mar 13, 2019
a33adaf
chore: bump atag version
wssgcg1213 Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/atag/src/components/input/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,15 @@ export default class Input extends PolymerElement {

/**
* Sync a-input value to real input value.
* @NOTE: If assign value to DOM Element directly, some iOS version of
* webview can not handle properly and to determintae insert composition process.
* To fix this, should judge value is equal first.
* @private
*/
_observeValue() {
this.$.input.value = this.value;
_observeValue(newValue) {
if (this.$.input.value !== newValue) {
this.$.input.value = newValue;
}
}

/**
Expand Down