Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: simple trigger source nilptr and ipset length error #391

Merged

Conversation

hhyasdf
Copy link
Collaborator

@hhyasdf hhyasdf commented Jun 28, 2023

Pull Request Description

Describe what this PR does / why we need it

  1. Fix nil pointer error which might happen in daemon during initializiation.
  2. Fix the error that ipv6 "local underlay net" ipset name is longer than 31 characters.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@hhyasdf hhyasdf force-pushed the bugfix/simpleTriggerSource-nilptr-error branch from fee98b9 to 52ce3f7 Compare June 28, 2023 07:38
@hhyasdf hhyasdf requested a review from mars1024 June 28, 2023 07:38
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (db35b39) 41.37% compared to head (cb47ce2) 41.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   41.37%   41.37%           
=======================================
  Files          42       42           
  Lines        2753     2753           
=======================================
  Hits         1139     1139           
  Misses       1498     1498           
  Partials      116      116           
Flag Coverage Δ
unittests 41.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hhyasdf hhyasdf force-pushed the bugfix/simpleTriggerSource-nilptr-error branch from 52ce3f7 to cb47ce2 Compare June 28, 2023 07:47
Copy link
Collaborator

@mars1024 mars1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mars1024 mars1024 merged commit b3bb24c into alibaba:main Jun 28, 2023
hhyasdf pushed a commit to hhyasdf/hybridnet that referenced this pull request Jun 28, 2023
…e-nilptr-error

bugfix: simple trigger source nilptr and ipset length error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants