Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CountDownLatch wait timeout in MetricFetcher when machine is dead #645

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

luoxn28
Copy link
Contributor

@luoxn28 luoxn28 commented Apr 2, 2019

Describe what this PR does / why we need it

in MetricFetche, if machine is dead, CountDownLatch will wait for timeout.

Does this pull request fix one issue?

Describe how you did it

if machine is dead, invoke latch.countDown()

Describe how to verify it

Special notes for reviews

@sczyh30 sczyh30 added the to-review To review label Apr 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #645 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #645      +/-   ##
============================================
- Coverage     40.49%   40.42%   -0.08%     
+ Complexity     1187     1184       -3     
============================================
  Files           267      267              
  Lines          7845     7845              
  Branches       1061     1061              
============================================
- Hits           3177     3171       -6     
- Misses         4272     4276       +4     
- Partials        396      398       +2
Impacted Files Coverage Δ Complexity Δ
...s/block/flow/controller/RateLimiterController.java 79.31% <0%> (-10.35%) 7% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LeapArray.java 67.64% <0%> (-2.95%) 33% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f20899...de358a5. Read the comment docs.

@sczyh30 sczyh30 added the area/dashboard Issues or PRs about Sentinel Dashboard label Apr 3, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 4b0960c into alibaba:master Apr 3, 2019
@sczyh30 sczyh30 removed the to-review To review label Apr 3, 2019
@sczyh30
Copy link
Member

sczyh30 commented Apr 3, 2019

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants