Skip to content

Commit

Permalink
Merge pull request #527 from alexrudall/pr523
Browse files Browse the repository at this point in the history
Add query params support
  • Loading branch information
alexrudall authored Oct 11, 2024
2 parents 03e76a7 + f33e969 commit 4627c94
Show file tree
Hide file tree
Showing 13 changed files with 894 additions and 5 deletions.
3 changes: 2 additions & 1 deletion lib/openai/http.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ def post(path:)
end&.body)
end

def json_post(path:, parameters:)
def json_post(path:, parameters:, query_parameters: {})
conn.post(uri(path: path)) do |req|
configure_json_post_request(req, parameters)
req.params = query_parameters
end&.body
end

Expand Down
4 changes: 2 additions & 2 deletions lib/openai/run_steps.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ def list(thread_id:, run_id:, parameters: {})
@client.get(path: "/threads/#{thread_id}/runs/#{run_id}/steps", parameters: parameters)
end

def retrieve(thread_id:, run_id:, id:)
@client.get(path: "/threads/#{thread_id}/runs/#{run_id}/steps/#{id}")
def retrieve(thread_id:, run_id:, id:, parameters: {})
@client.get(path: "/threads/#{thread_id}/runs/#{run_id}/steps/#{id}", parameters: parameters)
end
end
end
5 changes: 3 additions & 2 deletions lib/openai/runs.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ def retrieve(thread_id:, id:)
@client.get(path: "/threads/#{thread_id}/runs/#{id}")
end

def create(thread_id:, parameters: {})
@client.json_post(path: "/threads/#{thread_id}/runs", parameters: parameters)
def create(thread_id:, parameters: {}, query_parameters: {})
@client.json_post(path: "/threads/#{thread_id}/runs", parameters: parameters,
query_parameters: query_parameters)
end

def modify(id:, thread_id:, parameters: {})
Expand Down
97 changes: 97 additions & 0 deletions spec/fixtures/cassettes/file_search_assistant_setup.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

108 changes: 108 additions & 0 deletions spec/fixtures/cassettes/file_search_create_run.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

78 changes: 78 additions & 0 deletions spec/fixtures/cassettes/file_search_file_setup.yml

Large diffs are not rendered by default.

Loading

0 comments on commit 4627c94

Please sign in to comment.