Also offer completions for (var-) quoted symbols #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
commented
Mar 7, 2022
test/compliment/t_core.clj
Outdated
| @@ -22,7 +28,19 @@ | |||
| (strip-tags (core/completions "compliment.core/co")) | |||
| => (just ["compliment.core/completions"]) | |||
|
|
|||
| (strip-tags (core/completions "'compliment.core/co")) | |||
| => (just ["compliment.core/completions"]) | |||
There was a problem hiding this comment.
Hmm, from real-world usage (in cider + company-mode local installations), it seems that the actual completion should also include the prefix, else company-mode will not offer the completion.
Which makes sense: for #'x/, returning [x/a, x/b] would mean that the #' prefix is lost, which is not what one means.
There was a problem hiding this comment.
Fixed in the second commit.
It's working beautifully!
|
@vemv Looks good to me. Please mention it in the changelog and we're good to go. |
|
Actually I'll add the entry myself. Saves me dealing with merge conflicts there, now that there a few PRs to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alex,
it seemed to me that completions could be offered for quoted or var-quoted symbols.
Examples included as deftests.
The proposed solution is not particularly fancy, it might not be even be located in the best place but it might be at least a good conversation starter!
Build is green in my account:
Best wishes 🇺🇦