Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixes for namespaces in namespaced keywords don't have completion candidates #37

Closed
expez opened this issue Mar 7, 2016 · 6 comments

Comments

@expez
Copy link

expez commented Mar 7, 2016

If I do ::my-ns-alias/ then keywords in my-ns-alias are listed correctly, but the there's no completion suggestion while I'm typing ::my-ns-alias

@alexander-yakushev
Copy link
Owner

Do you mean there is no completion here my-ns-al█?

alexander-yakushev added a commit that referenced this issue Mar 7, 2016
@expez expez changed the title Prefixes for namespaced don't have completion candidates Prefixes for namespaces in namespaced keywords don't have completion candidates Mar 8, 2016
@expez
Copy link
Author

expez commented Mar 8, 2016

I've updated the OP slightly, I realize it was a bit unclear and I'm sorry about that. I filed it quicky while hacking on something else :p

Here's a more concrete example:

core.clj:

(ns test.core)

(def my-keywords #{::foo ::bar ::baz})

other.clj:

(ns test.other
  (:require [test.core :as my-ns-alias]))

(println ::my-ns-a|)

At the | there are no listed candidates, but I expected ::my-ns-alias to be listed. Once I write some more and and get to the slash (::my-ns-alias/) the completions work as expected and foo bar and baz show up.

@alexander-yakushev
Copy link
Owner

I see. Yes, I don't support that yet. Perhaps, keywords need the same treatment as vars in this regard. I will try to abstract some code away and implement this.

@alexander-yakushev
Copy link
Owner

@expez Could you please take a look at the commit and say if it is what you wanted?

@expez
Copy link
Author

expez commented Jun 19, 2016

Yes, this looks like what I wanted 👍

@alexander-yakushev
Copy link
Owner

I guess this should be resolved now :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants