Update to v9.0.4 and NVD API v2. #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Upgrades to ODC v9.0.4 and the NVD API v2 (see #314). Use without an NVD API key would otherwise be throttled (if not eventually dropped).
Description of Change
Upgraded to ODC v9.0.4 and adapted settings and documentation to match the new ODC core.
Have test cases been added to cover the new functionality?
Yes.
A new scripted test has been added that uses the NVD API key provided via system property. Note however that I did not try to adapt the other scripted tests to provide a NVD API key. In general all tests should eventually be updated to use an NVD API key that is generated for testing purposes for the project.