chore: switch react-helmet to react-helmet-async #45
+22
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for bulletproof-react-app ready! 🔨 Explore the source changes: 283ef20 🔍 Inspect the deploy log: https://app.netlify.com/sites/bulletproof-react-app/deploys/6187ef5cf92e0500074c93f6 😎 Browse the preview: https://deploy-preview-45--bulletproof-react-app.netlify.app/ |
TeXmeijin
changed the title
|
Thanks! |
inoy
pushed a commit
to inoy/bulletproof-react
that referenced
this pull request
Apr 19, 2023
chore: switch react-helmet to react-helmet-async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
Uninstall react-helmet and install react-helmet-async.
Why?
react-helmet is not maintained actively.
react-helmet has last commit at over 1 year ago.
https://github.com/nfl/react-helmet
react-helmet sometimes causes React warning
See following issue.
nfl/react-helmet#548
And it had not resolved.
react-helmet-async solves the problem and is actively maintained.
Please check following package.
https://www.npmjs.com/package/react-helmet-async
I use this at production service, then it works correctly.
Changes
react-helmet-async has almostly same interfaces and I had changed the library easily.
And I add HelmetProvider to app.tsx.