Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check documentMode and combine checks. #4

Merged
merged 1 commit into from
Feb 20, 2014
Merged

Check documentMode and combine checks. #4

merged 1 commit into from
Feb 20, 2014

Conversation

braddunbar
Copy link

I'm not certain of browser support for documentMode. /cc @jdalton

@jdalton
Copy link

jdalton commented Feb 19, 2014

The problem is document.documentMode wasn't added until IE8 and is available in IE8+ compat modes which is why the check was docMode was document.documentMode || 0.

There are other ways to infer IE7 though, it was missing native JSON, Object.definePropery, document.querySelectorAll.

@braddunbar
Copy link
Author

Ah, I see. Updated to just combine the checks then. Thanks @jdalton!

@braddunbar
Copy link
Author

Restored insertBefore as well.

akre54 added a commit that referenced this pull request Feb 20, 2014
Check `documentMode` and combine checks.
@akre54 akre54 merged commit feeab3f into akre54:history-native-hooks Feb 20, 2014
@braddunbar braddunbar deleted the history branch February 20, 2014 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants