-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try fading to black and other linters experiment #262
Conversation
@asvetlov failures can be adjusted, but I need you to validate the idea. |
Maybe apply black with default settings? |
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 99.71% 99.71%
=======================================
Files 4 4
Lines 355 355
=======================================
Hits 354 354
Misses 1 1
Continue to review full report at Codecov.
|
There's a number of other linters in pre-commit I'd like to keep and its config is quite a good place to consolidate options. We can try black with line-length arg, also I've applied ignore mode for quotes normalization. |
The main library contributor is me. |
I think you'd like to use tox the way I configure it: I'd run only your current python :) Of course, we can wrap it all with I like GNU make, and I've used it for quite a while, but for the problem that I describe it's just not a right tool. |
98d9e16
to
0c53068
Compare
😭 Failed to visit version page at https://readthedocs.org/dashboard/multidict/version/experiment-fade-black/. Please make sure you have enabled GitHub integration in your RTD project. |
Hey @asvetlov, here's my experiment on standardizing linters + trying to bring black in place.
What do you think?