Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fading to black and other linters experiment #262

Closed
wants to merge 7 commits into from

Conversation

webknjaz
Copy link
Member

Hey @asvetlov, here's my experiment on standardizing linters + trying to bring black in place.

What do you think?

@webknjaz
Copy link
Member Author

@asvetlov failures can be adjusted, but I need you to validate the idea.

@asvetlov
Copy link
Member

Maybe apply black with default settings?
Otherwise I'd like to have make black command.
But strings normalization and 90 chars line length looks OK if applied consistently.
IIRC emacs can read line length for the project from config file.

@codecov
Copy link

codecov bot commented Jun 20, 2018

Codecov Report

Merging #262 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files           4        4           
  Lines         355      355           
=======================================
  Hits          354      354           
  Misses          1        1
Impacted Files Coverage Δ
multidict/_abc.py 100% <ø> (ø) ⬆️
multidict/_multidict_py.py 99.68% <100%> (ø) ⬆️
multidict/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a338c...0c53068. Read the comment docs.

@webknjaz
Copy link
Member Author

There's a number of other linters in pre-commit I'd like to keep and its config is quite a good place to consolidate options. We can try black with line-length arg, also I've applied ignore mode for quotes normalization.
make is not a cross-platform thing and the way it's used now is really harmful especially for new non-experienced contributors. I'm going to give tox another try a bit later. It could unify the CI experience and help contributors a lot.

@asvetlov
Copy link
Member

The main library contributor is me.
I use Linux and found make very handy.
Pre-commit hook is perfect but I'd like to keep make tool.
Also, I don't use tox: it takes too long for building all possible environments.

@webknjaz
Copy link
Member Author

I think you'd like to use tox the way I configure it: I'd run only your current python :)
It looks like I just need to show you better workflow with it.

Of course, we can wrap it all with make, I just want to untangle spaghetti there.
Also, think big: it's better to standardize tooling across all repos and in this case contributors matter.

I like GNU make, and I've used it for quite a while, but for the problem that I describe it's just not a right tool.

@webknjaz
Copy link
Member Author

@asvetlov I've made a demo of how it might look like with tox-centric setup. It cleans up CI setup a bit and makes test runner truly cross-platform: #263

@webknjaz webknjaz force-pushed the experiment/fade-black branch from 98d9e16 to 0c53068 Compare July 19, 2018 09:32
@webknjaz webknjaz closed this Dec 17, 2018
@rtd-helper
Copy link

rtd-helper bot commented Dec 17, 2018

😭 Failed to visit version page at https://readthedocs.org/dashboard/multidict/version/experiment-fade-black/. Please make sure you have enabled GitHub integration in your RTD project.

@asvetlov asvetlov deleted the experiment/fade-black branch December 19, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants