Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update query on tracing functions #7724

Closed
wants to merge 2 commits into from
Closed

Fix update query on tracing functions #7724

wants to merge 2 commits into from

Conversation

bharel
Copy link

@bharel bharel commented Oct 18, 2023

What do these changes do?

Fixed update query on tracing functions. Query parameters will not be removed.

Regarding the unittest - seems like there are UTs, but they aren't catching it for some reason.

Are there changes in behavior for the user?

Not really, unless someone uses the raw url string, which should now be accurate.

Related issue number

Closes #7722

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@bharel bharel requested a review from asvetlov as a code owner October 18, 2023 02:46
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 18, 2023
@bharel
Copy link
Author

bharel commented Oct 18, 2023

Seems like this issue was fixed in the master version, I apologize.

@bharel bharel closed this Oct 18, 2023
@bharel
Copy link
Author

bharel commented Oct 18, 2023

Duplicate of #7259.

@Dreamsorcerer
Copy link
Member

Try it in 3.9.0b0, should already be in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aiohttp removes query params passed to trace function
2 participants