Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6002/d66e07c6 backport][3.8] Add xfailing integration tests against proxy.py #6033

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Oct 3, 2021

This is a backport of PR #6002 as merged into master (d66e07c).

This patch adds full end-to-end tests for sending requests to HTTP and
HTTPS endpoints through an HTTPS proxy. The first case is currently
supported and the second one is not. This is why the latter test is
marked as expected to fail. The support for TLS-in-TLS in the upstream
stdlib asyncio is currently disabled but is available in Python 3.9
via monkey-patching which is demonstrated in the added tests.

Refs:

Co-authored-by: Sviatoslav Sydorenko [email protected]

PR #6002

(cherry picked from commit d66e07c)

This patch adds full end-to-end tests for sending requests to HTTP and
HTTPS endpoints through an HTTPS proxy. The first case is currently
supported and the second one is not. This is why the latter test is
marked as expected to fail. The support for TLS-in-TLS in the upstream
stdlib asyncio is currently disabled but is available in Python 3.9
via monkey-patching which is demonstrated in the added tests.

Refs:
* https://bugs.python.org/issue37179
* python/cpython#28073
* aio-libs#5992

Co-authored-by: Sviatoslav Sydorenko <[email protected]>

PR aio-libs#6002

(cherry picked from commit d66e07c)
@webknjaz webknjaz added client infra python Pull requests that update Python code labels Oct 3, 2021
@webknjaz webknjaz requested a review from asvetlov as a code owner October 3, 2021 18:33
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 3, 2021
@webknjaz webknjaz enabled auto-merge (squash) October 3, 2021 18:34
@webknjaz webknjaz added this to the 3.8 milestone Oct 3, 2021
@webknjaz webknjaz merged commit ed8f834 into aio-libs:3.8 Oct 3, 2021
@webknjaz webknjaz deleted the patchback/backports/3.8/d66e07c652322d280740106ebb9946a3dd7daf5b/pr-6002 branch April 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR client infra python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants