Fix race condition on connect when tracing is active (#5259) (#5285)

aio-libs · Nov 26, 2020 · 9cb5a7e · 9cb5a7e
1 parent dd682fb
commit 9cb5a7e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/CHANGES/5259.bugfix b/CHANGES/5259.bugfix
@@ -0,0 +1 @@
+Acquire the connection before running traces to prevent race condition.
diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt
@@ -48,6 +48,7 @@ Arthur Darcet
 Ben Bader
 Ben Timby
 Benedikt Reinartz
+Bob Haddleton
 Boris Feld
 Boyi Chen
 Brett Cannon

diff --git a/aiohttp/connector.py b/aiohttp/connector.py
@@ -553,8 +553,14 @@ async def connect(
                     await trace.send_connection_create_end()
         else:
             if traces:
+                # Acquire the connection to prevent race conditions with limits
+                placeholder = cast(ResponseHandler, _TransportPlaceholder(self._loop))
+                self._acquired.add(placeholder)
+                self._acquired_per_host[key].add(placeholder)
                 for trace in traces:
                     await trace.send_connection_reuseconn()
+                self._acquired.remove(placeholder)
+                self._drop_acquired_per_host(key, placeholder)
 
         self._acquired.add(proto)
         self._acquired_per_host[key].add(proto)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Acquire the connection before running traces to prevent race condition.