Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker classes shall be detected automatically (aka CheckerFactory) #185

Open
gernotstarke opened this issue Aug 20, 2018 · 0 comments
Open

checker classes shall be detected automatically (aka CheckerFactory) #185

gernotstarke opened this issue Aug 20, 2018 · 0 comments
Assignees
@gernotstarke
Labels
enhancement in progress

Comments

@gernotstarke
Copy link
Member

currently, the Checker classes are manually instantiated (in AllChecksRunner), violating the OpenClose principle.

That could be solved programatically, i.e. via a custom annotation or a reflection-based approach.

Open: how to test such behavior?
@gernotstarke gernotstarke self-assigned this Aug 20, 2018
@gernotstarke gernotstarke changed the title checker classes shall be detected automatically checker classes shall be detected automatically (aka CheckerFactory) Aug 25, 2018
@gernotstarke gernotstarke mentioned this issue Feb 7, 2019
Closed
ascheman added a commit that referenced this issue Sep 17, 2024
@ascheman
Replace missing (outdated) external link wrt. #185
5eec996 
- Original article by Przemysław Wojnowski (https://farenda.com/spring-find-annotated-classes/)
  seems to have vanished -> Add generic Baeldung article
- unify design discussions
- add current state of issues (open/close)
- Drop "plantumldir" AsciiDoctor attribute as it is not necessary
ascheman added a commit that referenced this issue Sep 17, 2024
@ascheman
Replace missing (outdated) external link wrt. #185
32d2451 
- Original article by Przemysław Wojnowski (https://farenda.com/spring-find-annotated-classes/)
  seems to have vanished -> Add generic Baeldung article
- unify design discussions
- add current state of issues (open/close)
- Drop "plantumldir" AsciiDoctor attribute as it is not necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gernotstarke gernotstarke

Labels
enhancement in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gernotstarke