-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HalfCauchyRV
JAX implementation
#1370
Conversation
HalfCauchyRV
JAX implementation
Also, n00b git question. What the correct git for rebasing and changing the commit name? I f'd it up a bit last time. I just ran |
To pull from upstream and rebase To rename a commit |
Well I did the rebase but I made a mess again lol. I'll have a look after the football. Don't merge yet and I'll let you know if I can't fix it |
Don't hesitate to ask for help! |
Hey, yeah I'm not sure how to do this unfortunately. I can only seem to amend the 14 rebase commits rather than the 2 I added. And there's no option to squash. Please let me know how you fix this and I'll never ask again next time I contribute Also, the workflows are failing but that isn't to do with me by the looks of it. My tests pass locally |
924ee9e
to
3a213f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theorashid, I dropped the merge commit (well, all the commits added by the merge commit), squared the typo fix commit into the original feature commit, and rebased the resulting single commit onto upstream/main
. The last step should not introduce any new commits. You can use the command-line interactive rebasing to do the same thing locally; otherwise, you can pull in the changes from your remote branch by rebasing and ignoring any local conflicts.
Great, thank you. This should be good to go. btw I'm used to repos which squash all commits before merging for pull requests |
3a213f7
to
1bd931f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1370 +/- ##
=======================================
Coverage 74.66% 74.66%
=======================================
Files 177 177
Lines 49050 49060 +10
Branches 10400 10400
=======================================
+ Hits 36623 36633 +10
Misses 10131 10131
Partials 2296 2296
|
It is only one commit now. Thanks for your contribution! |
This is for #1334. Hopefully it's as obvious as the halfnormal
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.