Run Alembic migrations on Hyperion startup #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rotheem
force-pushed
the
full-migration-setup
branch
from
dac7717 to
442a0bd
Compare
|
We may want to experiment adding https://alembic.sqlalchemy.org/en/latest/cookbook.html#building-an-up-to-date-database-from-scratch |
armanddidierjean
force-pushed
the
full-migration-setup
branch
from
fc4f019 to
1de93f9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
+ Coverage 78.14% 78.88% +0.74%
==========================================
Files 77 77
Lines 5400 5528 +128
==========================================
+ Hits 4220 4361 +141
+ Misses 1180 1167 -13 ☔ View full report in Codecov by Sentry. |
armanddidierjean
changed the title
Rotheem
force-pushed
the
full-migration-setup
branch
from
b8caab1 to
27d7ccf
Compare
Rotheem
added
ready for review
Rotheem
requested review from
guillaumetavernier,
Petitoto,
Nathanael-lscx,
Jake-Ransom,
Pokegali and
julien4215
…g event loop by wrapping it in a SQLAchemy run_sync and from the CLI without an event loop
during migrations
instead of engine.connect
instead of running all migration files one by one
tables in the database and in the models
instead of an AsyncConnection
armanddidierjean
force-pushed
the
full-migration-setup
branch
from
27d7ccf to
4bfa3d3
Compare
Petitoto
approved these changes
Feb 4, 2024
armanddidierjean
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this pull request we only created missing tables on Hyperion startup. The developer had to run migrations files mannually when a table was modified.
With this PR, Hyperion: