Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using chips on Ember (CLI) 2.13: expected an implementation for 6 #705

Closed
backspace opened this issue May 1, 2017 · 17 comments
Closed

Comments

@backspace
Copy link
Contributor

Hey, thanks for all the work on this, it’s been helpful for me to have a lot of UI taken care of so I can focus on business logic.

I tried updating an application to Ember 2.13 today and ran into this error in the console, with part of the UI failing to render:

ember.debug.js:19829 Error: expected an implementation for 6

Stacktrace
    at Object.debugAssert [as assert] (ember.debug.js:1498)
    at Compilers.compile (ember.debug.js:1201)
    at compileStatement (ember.debug.js:1200)
    at ember.debug.js:1200
    at Array.forEach ()
    at WrappedBuilder.compile (ember.debug.js:1200)
    at ComponentLayoutBuilder.compile (ember.debug.js:1173)
    at Object.compileLayout (ember.debug.js:1173)
    at Cache._emberMetal.Cache.owner [as func] (ember.debug.js:11330)
    at Cache.get (ember.debug.js:18578)

I tracked it down to this line in my header template:

{{#paper-chips readOnly=true content=chips as |item|}}<span title='{{item.title}}'>{{item.label}}</span>{{/paper-chips}}

I’m admittedly using chips outside their intended purpose, just to show an indicator in the header when you’re viewing a “sandbox” site. I can accomplish this differently without using chips, I was just being lazy about CSS etc.

I’ve removed the use of paper-chips for now but hopefully I’ll find some time to look into this and propose a fix.

My limited investigation has shown me that the failure is unrelated to the block use; even when I changed the template to this it still produced the same error:

{{paper-chips readOnly=true content=chips}}

It’s my belief that this relates to Babel 6, based on the text of the error, but it’s pretty mysterious!

@bjornharrtell
Copy link
Contributor

The same error message popped up in #578 but was worked around.. would be good to find out what the real cause is though.

@backspace
Copy link
Contributor Author

Thanks for that connexion, @bjornharrtell. I wonder if this is actually a missing tag from the new Glimmer that uses integers to represent tags?

@backspace
Copy link
Contributor Author

Thanks to insight from @rwjblue on the Ember Community Slack, it looks like this is a manifestation of this known issue. As he suggested, when I changed the md-chips-wrap and md-chip elements to be divs instead, the error disappeared.

I’ll write about this on that thread.

@nizarayari
Copy link

nizarayari commented May 19, 2017

Anyone found a simple solution for this issue?

@Subtletree
Copy link
Collaborator

For now I've just changed ember-source to 2.12.0 in package.json

@nizarayari
Copy link

There is no work around? bc I cannot change back to 2.12

@Subtletree
Copy link
Collaborator

Unfortunately I don't think there is a work around except fixing these 2 issues in glimmer : (

glimmerjs/glimmer-vm#493
glimmerjs/glimmer-vm#494

What's blocking you from dropping back to 2.12?

@rwjblue
Copy link
Member

rwjblue commented May 21, 2017

FWIW, I am working on those two issues. Hope to have something for the rest of the glimmer team to review tomorrow. Unfortunately, there are some compounding factors in glimmer-vm ATM. Basically, Ember 2.13/2.14 are using glimmer-vm packages at 0.22.x, but master is a significantly different architecture. So any changes we make at this point have to be fixed twice 😭 ...

@nizarayari
Copy link

Thanks for your great work @rwjblue. @Subtletree , is there any better glimmer perf for your app with 2.13?

@Subtletree
Copy link
Collaborator

I basically just upgraded to 2.13, hit these issues then dropped back to 2.12 so didn't get a chance to test it. Still have ember-cli 2.13 though so get ember install with yarn etc which is awesome.

🥇 rwjblue!

@nizarayari
Copy link

Hey guys, do you have any idea when this issue will be fixed? thanks

@bjornharrtell
Copy link
Contributor

There is a good chance it's fixed with the recently released Ember 2.13.3, but have not confirmed yet. Planning to do that today when updating #709.

@bjornharrtell
Copy link
Contributor

bjornharrtell commented Jun 1, 2017

Confirmed that Ember 2.13.3 resolves this issue (at least when using Chips as in the demo page).

@nizarayari
Copy link

Worked for me as well after upgrading to "ember-source": "~2.13.3"

@miguelcobain
Copy link
Collaborator

To everyone involved in this fix, thank you!

@bjornharrtell
Copy link
Contributor

This issue has been fixed as of #709, so should be closed.

backspace added a commit to backspace/prison-rideshare-ui that referenced this issue Jul 5, 2017
@backspace
Copy link
Contributor Author

It’s true, it worked for me with Ember 2.13.3! Thanks, all. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants