Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Group structured data issues before generating suggestions #760

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

herzog31
Copy link
Member

@herzog31 herzog31 commented Mar 7, 2025

We observed customers which had the same structured data issue on hundreds of pages. This PR aims to reduce the amount of redundant requests made in these scenarios.

  • De-duplicate errors reported from GSC.
    • e.g. breadcrumb with 5 items where all 5 items are missing an attribute previously causes 5 Missing field "name" errors.
    • Multiple errors for the same entity are combined into a single issue.
  • Once a suggestion for a specific issue was created, it is cached and can be re-used for other pages that have the exact some issue.
    • e.g. if the same issue for the breadcrumb entity happens on 5 pages, only the first page will generate a suggestion. The other 4 pages will re-use the suggestion from the first page.
  • Introduced a hard limit of 50 Firefall requests per audit as a failsafe to prevent timeouts. This can be increased later if needed.
  • The scrape for a page is now only retrieved if all conditions are met to generate a suggestion using Firefall.
  • Reduced number of debug logs and added page URLs to all log messages.
  • Updated unit tests.

Related Issues

See SITES-29354 for more details.

@herzog31 herzog31 added the enhancement New feature or request label Mar 7, 2025
@herzog31 herzog31 requested review from dzehnder and a team March 7, 2025 14:54
Copy link

github-actions bot commented Mar 7, 2025

This PR will trigger no release when merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant