Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating Optimze.java to OptimizeImple.kt #124

Open
wants to merge 7 commits into
base: dev-v3.2.3
Choose a base branch
from

Conversation

siddique-adobe
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 79.67033% with 37 lines in your changes missing coverage. Please review.

Project coverage is 84.21%. Comparing base (df20f56) to head (0d763ff).

Files with missing lines Patch % Lines
...om/adobe/marketing/mobile/optimize/OptimizeImpl.kt 78.66% 21 Missing and 14 partials ⚠️
...adobe/marketing/mobile/optimize/OptimizeUtils.java 83.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             dev-v3.2.3     #124      +/-   ##
================================================
+ Coverage         83.42%   84.21%   +0.78%     
- Complexity          230      232       +2     
================================================
  Files                 9       10       +1     
  Lines              1104     1108       +4     
  Branches            177      165      -12     
================================================
+ Hits                921      933      +12     
+ Misses              102       96       -6     
+ Partials             81       79       -2     
Flag Coverage Δ
functional-tests 54.33% <41.21%> (+0.26%) ⬆️
unit-tests 82.13% <78.02%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../com/adobe/marketing/mobile/optimize/Optimize.java 100.00% <100.00%> (+23.94%) ⬆️
...adobe/marketing/mobile/optimize/OptimizeUtils.java 83.33% <83.33%> (ø)
...om/adobe/marketing/mobile/optimize/OptimizeImpl.kt 78.66% <78.66%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants