Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Replace openssl 1.1 with openssl 3 #10851

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

sarathrajsrinivasan
Copy link
Contributor

@sarathrajsrinivasan sarathrajsrinivasan commented Oct 23, 2024

Description

OpenSSL 1.1 is deprecated and removed from Homebrew. We are replacing it with OpenSSL 3.

Warning: [email protected] has been deprecated! It will be disabled on 2024-10-24.

Related issue:

#10817

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@erik-bershel erik-bershel merged commit d4872d4 into actions:main Oct 24, 2024
4 checks passed
@erik-bershel erik-bershel deleted the macos-openssl-deprecation branch October 24, 2024 09:44
karol-pieciukiewicz pushed a commit to azure-way/actions-runner-images that referenced this pull request Nov 11, 2024
$commandResult = Get-CommandResult "openssl version"
$commandResult.Output | Should -Match "OpenSSL 1.1"
$commandResult.Output | Should -Match "OpenSSL 3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first-level heading

A second-level heading

A third-level heading

$commandResult = Get-CommandResult "openssl version"
$commandResult.Output | Should -Match "OpenSSL 1.1"
$commandResult.Output | Should -Match "OpenSSL 3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text that is not a quote

Text that is a quote

@@ -7,17 +7,17 @@ Describe "OpenSSL" {
}
}

Context "OpenSSL 1.1 Path Check" {
It "OpenSSL 1.1 path exists" {
$openSSLpath = brew --prefix [email protected]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$openSSLpath = brew --prefix openssl@1.1
Context "OpenSSL 3 Path Check" {
It "OpenSSL 3 path exists" {
$openSSLpath = brew --prefix openssl@3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$openSSLpath = brew --prefix openssl@1.1
Context "OpenSSL 3 Path Check" {
It "OpenSSL 3 path exists" {
$openSSLpath = brew --prefix openssl@3
$openSSLpath | Should -Exist

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$openSSLpath | Should -Exist
}
}

Context "OpenSSL 1.1 is default" {
It "Default OpenSSL version is 1.1" {
Context "OpenSSL 3 is default" {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context "OpenSSL 1.1 is default" {
It "Default OpenSSL version is 1.1" {
Context "OpenSSL 3 is default" {
It "Default OpenSSL version is 3" {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# #11646

Copy link

@wai2much wai2much left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants