Added Meter ID/Name to MQTT message. #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd reliable reference to link messages -> event files -> meters.
teknofire
approved these changes
Sep 6, 2024
|
Looks like the bats tests for the scripts need to be updated |
The bat tests are now updated with the new changes. |
teknofire
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the meter ID directly to the MQTT message, allowing the Rails API to reliably link event files to their corresponding meters. Previously, this link was established by parsing the file path, which proved unreliable due to potential changes in the path structure. Including the meter ID in the message ensures a consistent and reliable reference, improving data integrity and reducing the risk of linkage errors.