Add option for VRRP address owner to drop received adverts #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 9568 (and RFC 5798 and RFC 3768) state that an address owner must drop any received VRRP packets. The consequence of this is that if there is more than one VRRP instance configured with priority 255 then they will all be in master state simultaneously. It seems more sensible for such received packets to be processed normally, and all but the VRRP instance with the primary IP address will revert to backup state. RFC 9568 appears to allow more than one instance to have priority 255, since section 8.3.2 was changed from "No more than one router on the link is to be configured with priority 255, especially if preemption is set" (note the contradiction here) to "only a single VRRP Router on the link SHOULD be configured with priority 255" and then descibes the situation if there is more than one such router. keepalived defaults to processing received packets when the local priority is 255, but the option added by this patch allows working in accordance with the RFC, i.e. to drop any received packets. Signed-off-by: Quentin Armitage <[email protected]>
Signed-off-by: Quentin Armitage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.