This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Expose task metrics for Prometheus #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrabovsky
force-pushed
the
metrics
branch
2 times, most recently
from
756cf7c to
2ee3092
Compare
* Use HTTPS everywhere. * Remove some outdated information. * Use `@var` instead of `@command` for configuration options.
Factor out the path to /usr/bin/ps into a compile-time variable and add a dependency on procps-ng in the spec file.
/usr/bin/df from coreutils is used to check for free disk space. Also remove some duplicate dependencies.
Introduce a new HTTP endpoint `/metrics` serving basic figures regarding retrace tasks in a machine readable format. This allows integration with a Prometheus server. The following metrics are exposed at the moment: - Free disk space on volume where task data are located (`/var/spool/retrace-server` by default). - Number of retrace workers currently running. - Total number of retrace jobs denied because of exceeded server capacity (see the `MaxParallelTasks` configuration option). - Total number of retrace tasks finished by result -- failed or successful.
Add a configuration option for exposing the metrics endpoint. Keep it disabled by default.
msrb
approved these changes
Apr 23, 2021
|
OK, I'll just go ahead and merge this. We can watch how it performs on retrace-stg for now and tweak details later. |
This was referenced May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new HTTP endpoint
/metricsserving basic figures regarding retrace tasks in a machine readable format. This allows integration with a Prometheus server.The following metrics are exposed at the moment:
/var/spool/retrace-serverby default).MaxParallelTasksconfiguration option).See https://retrace-stg.aws.fedoraproject.org/metrics for a testing version.