Add bulk search in v2 #1649
Merged
Add bulk search in v2 #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
tdruez
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
@TG1999 The bulk_search looks fine and I can start working on code changes on the DejaCode side to consume the new datastructure.
Now, please remove
Fixes #1561
Fixes #1538
Fixes #1572
from your description as this PR alone does not entirely fix any of those.
There are still a few things from those tickets to address, such as #1572 (comment) and #1572 (comment)
This is not in the way of merging this progress though. Just make sure the issues are still open for now and there is more to be done.
TG1999
force-pushed
the
add-bulk-search-v2
branch
from
06c4038 to
b071a51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.