Return correct block for Scilla CURRENTBLOCK query
#2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHinshelwood
force-pushed
the
fix-fork
branch
2 times, most recently
from
aa6b650 to
3ad7c12
Compare
|
Bencher Report| Branch | fix-fork |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,085.00 ms(+0.41%)Baseline: 1,080.59 ms | 1,427.69 ms (76.00%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 439.66 ms(+8.61%)Baseline: 404.81 ms | 489.09 ms (89.89%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 3,372.90 ms(-16.44%)Baseline: 4,036.56 ms | 5,640.60 ms (59.80%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 10.31 ms(+3.26%)Baseline: 9.98 ms | 10.72 ms (96.14%) |
JamesHinshelwood
commented
Mar 7, 2025
JamesHinshelwood
force-pushed
the
fix-fork
branch
2 times, most recently
from
0624fab to
f0a164f
Compare
Instead of always using the latest block of the chain, we pass the 'current' block from the execution layer. This means the transactions can be replayed and produce the same result. This also limits the maximum range of `BLOCKHASH` and `TIMESTAMP` queries to 256 blocks from the current block.
JamesHinshelwood
force-pushed
the
fix-fork
branch
from
f0a164f to
16f367f
Compare
86667
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation incorrectly returned
CURRENTBLOCKas the number of the last mined block. This adds a fork which fixes the behaviour to return the current block. Also, the latest block of the chain was always used. Instead we now pass the current block from the execution layer, meaning transactions can be replayed and produce the same result.This also limits the maximum range of
BLOCKHASHandTIMESTAMPqueries to 256 blocks from the current block.