Fix deque implementation in deposit contract #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86667
reviewed
Feb 25, 2025
|
Bencher Report| Branch | fix-deque |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,205.70 ms(+4.80%)Baseline: 1,150.50 ms | 1,532.56 ms (78.67%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 389.16 ms(-8.12%)Baseline: 423.57 ms | 528.19 ms (73.68%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 3,318.10 ms(-14.29%)Baseline: 3,871.40 ms | 5,226.75 ms (63.48%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 10.00 ms(+3.98%)Baseline: 9.62 ms | 11.85 ms (84.42%) |
JamesHinshelwood
force-pushed
the
fix-deque
branch
from
bf57109 to
6a287ef
Compare
|
Fixes #2400 |
The old implementation was objectively broken and unnecessarily complicated. Instead, we just store elements in a `mapping(index => element)`.
JamesHinshelwood
force-pushed
the
fix-deque
branch
from
6af78aa to
a2ec890
Compare
86667
approved these changes
Feb 26, 2025
JamesHinshelwood
added a commit
that referenced
this pull request
Feb 28, 2025
PR #2402 forgot to update the chain specs. This also adds a script to easily update the spec files for all networks.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 28, 2025
PR #2402 forgot to update the chain specs. This also adds a script to easily update the spec files for all networks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation was objectively broken and unnecessarily complicated. Instead, we just store elements in a
mapping(index => element).