Altered behaviour of GetTransactionStatus #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | max/fix/2167-incorrect-status-returned-by-gettransactionstatus |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,082.20 ms(-5.84%)Baseline: 1,149.32 ms | 1,532.38 ms (70.62%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 449.45 ms(+5.75%)Baseline: 425.02 ms | 528.84 ms (84.99%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 3,379.50 ms(-12.46%)Baseline: 3,860.67 ms | 5,218.62 ms (64.76%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 10.32 ms(+7.43%)Baseline: 9.60 ms | 11.87 ms (86.92%) |
|
See discussion in #2167 |
- rewrite of status code calculation - docs updates - now handles transactions that aren't in a block more correctly
…ttransactionstatus
- Removed comments indicating deprecated options in status enum - Refactored state decision code from api/types/zil.rs to api/zilliqa.rs - Fixed finalization checking logic
JamesHinshelwood
previously approved these changes
Jan 27, 2025
- refactored handling of missing receipts - cut down on a vec iteration in looking up transaction pending/queued
…ttransactionstatus
…ttransactionstatus
JamesHinshelwood
previously approved these changes
Feb 19, 2025
…ttransactionstatus
JamesHinshelwood
approved these changes
Feb 26, 2025
maxconway
deleted the
max/fix/2167-incorrect-status-returned-by-gettransactionstatus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm very open to different logic if anyone knows better exactly what the behaviour should be here.
Intended to fix #2167