Fix transactions where Scilla messages are sent to EVM contracts #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct behaviour is that EVM contracts should be treated as if they were EOAs in most non-exceptional cases. The exceptional cases are mentioned in #1610 and we'll make another change to this logic to deal with them later. This PR just adds the easy case and treats all EVM contracts as EOAs. For now, we just enable this change in the proto-testnet, where we can easily update the nodes by the time the fork height is reached in ~1.5 days. There are further execution changes being worked on that we can release together in a single fork on the proto-mainnet.
|
Bencher Report| Branch | fix-scilla-call-to-evm |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 8.39 (-8.93%) | 10.35 (81.10%) |
| produce-full/produce-full | 📈 view plot 🚷 view threshold | 1,719.20 (-12.32%) | 2,274.86 (75.57%) |
DrZoltanFazekas
approved these changes
Jan 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct behaviour is that EVM contracts should be treated as if they were EOAs in most non-exceptional cases. The exceptional cases are mentioned in #1610 and we'll make another change to this logic to deal with them later. This PR just adds the easy case and treats all EVM contracts as EOAs.
For now, we've just enabled this change in the proto-testnet, where we can easily update the nodes by the time the fork height is reached in ~1.5 days. There are further execution changes being worked on that we can release together in a single fork on the proto-mainnet.