Refactor sync out of block_store.rs #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-zil
commented
Jan 6, 2025
|
Bencher Report| Branch | 2039-refactor-blockstore |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,193.00 (-9.95%) | 1,799.10 (66.31%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 381.35 (-32.92%) | 765.15 (49.84%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 4,057.60 (-1.24%) | 5,194.08 (78.12%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 9.70 (+10.49%) | 10.50 (92.44%) |
shawn-zil
force-pushed
the
2039-refactor-blockstore
branch
8 times, most recently
from
e5482f3 to
6768786
Compare
shawn-zil
force-pushed
the
2039-refactor-blockstore
branch
17 times, most recently
from
5fb4bf9 to
e6e96bb
Compare
This was
linked to
issues
Jan 31, 2025
Closed
This was
unlinked from
issues
Jan 31, 2025
Closed
Closed
This was
linked to
issues
Jan 31, 2025
Closed
shawn-zil
force-pushed
the
2039-refactor-blockstore
branch
2 times, most recently
from
8bc3ac6 to
a98d900
Compare
JamesHinshelwood
previously approved these changes
Feb 3, 2025
shawn-zil
force-pushed
the
2039-refactor-blockstore
branch
from
a98d900 to
071d40b
Compare
JamesHinshelwood
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to take the block syncing feature out of block_store.rs.
It performs syncing using a 3-phase mechanism:
It is working on the local docker cluster - a new node is able to sync from genesis, and sync from elsewhere in history.