Add ability to enable/disable APIs via configuration #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzawisto
previously approved these changes
Dec 9, 2024
JamesHinshelwood
force-pushed
the
api-config
branch
from
d4248ee to
767234b
Compare
JamesHinshelwood
commented
Dec 9, 2024
86667
reviewed
Dec 9, 2024
86667
reviewed
Dec 9, 2024
JamesHinshelwood
force-pushed
the
api-config
branch
from
767234b to
69914e2
Compare
86667
reviewed
Dec 9, 2024
JamesHinshelwood
force-pushed
the
api-config
branch
from
a675861 to
397a2f2
Compare
|
Bencher Report| Branch | api-config |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 8,521,900.00 (-6.99%) | 10,862,816.59 (78.45%) |
| produce-full/produce-full | 📈 view plot 🚷 view threshold | 2,517,600,000.00 (-1.95%) | 2,727,329,359.48 (92.31%) |
JamesHinshelwood
commented
Dec 9, 2024
JamesHinshelwood
force-pushed
the
api-config
branch
4 times, most recently
from
e5144c7 to
83c4325
Compare
JamesHinshelwood
force-pushed
the
api-config
branch
from
83c4325 to
c42bd2a
Compare
By default all JSON-RPC API methods are now disabled. API methods
must be enabled with the `enabled_apis` property in configuration.
Entire namespaces can be enabled at once with a string (e.g.
`"eth"`) or individual methods can be enabled with an object of
the form `{ namespace = "eth", apis = ["blockNumber"] }`. For the
purposes of this configuration, any method without a namespace
(i.e. without an underscore) is assumed to be under the `zilliqa`
namespace.
The infrastructure configuration enables all API namespaces except
`admin` for API nodes and only enables `eth_blockNumber` for all
other node types.
…ent configuration
JamesHinshelwood
force-pushed
the
api-config
branch
from
c42bd2a to
0cef06b
Compare
86667
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default all JSON-RPC API methods are now disabled. API methods must be enabled with the
enabled_apisproperty in configuration. Entire namespaces can be enabled at once with a string (e.g."eth") or individual methods can be enabled with an object of the form{ namespace = "eth", apis = ["blockNumber"] }. For the purposes of this configuration, any method without a namespace (i.e. without an underscore) is assumed to be under thezilliqanamespace.Nodes are also now able to start the JSON-RPC server on more than one port, each of which can have different configuration.