Don't execute transactions unless they will definitely fit in a block #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHinshelwood
requested review from
bzawisto,
86667,
DrZoltanFazekas and
shawn-zil
JamesHinshelwood
changed the title
Previously, we would optimistically execute transactions from the pool, even if their gas limit exceeded the remaining gas, in case they actually used less gas after being executed. However, this means we need to commit state after each transaction and unwind changes if our optimistic guess was wrong. Instead, we make the pessimistic assumption that transaction gas limits are accurate and don't execute a transaction unless we are guaranteed to have enough space for it.
JamesHinshelwood
force-pushed
the
dont-pull-big-txns
branch
from
101afcf to
a076a6f
Compare
shawn-zil
approved these changes
Dec 4, 2024
shawn-zil
added a commit
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would optimistically execute transactions from the pool, even if their gas limit exceeded the remaining gas, in case they actually used less gas after being executed.
However, this means we need to commit state after each transaction and unwind changes if our optimistic guess was wrong. Instead, we make the pessimistic assumption that transaction gas limits are accurate and don't execute a transaction unless we are guaranteed to have enough space for it.