Update eth_getBlockByNumber and eth_getBlockByHash to match spec #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxconway
commented
Nov 25, 2024
maxconway
commented
- Removed view, mixhash, quorumCertificate, since they're not in Etherium spec
- Added comments for why placeholders are placeholders
maxconway
force-pushed
the
max/bugfix/eth_getBlockByNumberOrHash
branch
from
f77e80b to
41a623c
Compare
- Removed view, mixhash, quorumCertificate, since they're not in Etherium spec - Added comments for why placeholders are placeholders
- Moved it from the header to the body of the block return type. The header is flattened so this should work the same way, but avoided the relatively slow process of building the bloom filter for endpoints that don't need it.
maxconway
force-pushed
the
max/bugfix/eth_getBlockByNumberOrHash
branch
from
2554098 to
a85a213
Compare
Fixed code to avoid getting stuck But querying everything every time in order to build a bloom filter doesn't necessarily make sense, so we should look at this further
maxconway
force-pushed
the
max/bugfix/eth_getBlockByNumberOrHash
branch
from
a85a213 to
053b498
Compare
|
Bencher Report| Branch | max/bugfix/eth_getBlockByNumberOrHash |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 9.55 (+3.85%) | 10.41 (91.77%) |
| produce-full/produce-full | 📈 view plot 🚷 view threshold | 1,918.00 (-5.65%) | 2,624.77 (73.07%) |
JamesHinshelwood
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.