Batch SQL inserts for transactions #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHinshelwood
force-pushed
the
batch-insert-txns
branch
2 times, most recently
from
0f8b802 to
1020a68
Compare
shawn-zil
reviewed
Nov 26, 2024
JamesHinshelwood
force-pushed
the
batch-insert-txns
branch
from
1020a68 to
c96597d
Compare
I've seen that SQL insert latency is a large bottleneck for the execution of blocks with many transactions. By batching these transactions and performing them all with a single SQL query at the end of executing a block, we should reduce this latency.
JamesHinshelwood
force-pushed
the
batch-insert-txns
branch
from
c96597d to
4cf2071
Compare
shawn-zil
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen that SQL insert latency is a large bottleneck for the execution of blocks with many transactions. By batching these transactions and performing them all with a single SQL query at the end of executing a block, we should reduce this latency.