Implement GetTransactionStatus API #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxconway
force-pushed
the
max/feature/get_transaction_status
branch
2 times, most recently
from
cdf98e1 to
4e2f793
Compare
- Also changed some API placeholder names to snakecase Transaction status code is returned as: - 3 if the transaction receipt shows successfully accepted, - 1 if it is not yet accepted - my guess at the most appropriate error from the docs if there is one error - 255 (internal error) for multiple errors
maxconway
force-pushed
the
max/feature/get_transaction_status
branch
from
7507364 to
5d196c7
Compare
bzawisto
approved these changes
Nov 5, 2024
| pub last_modified: String, | ||
| #[serde(rename = "modificationState")] | ||
| pub modification_state: u64, | ||
| pub status: u64, |
There was a problem hiding this comment.
It might be useful to link to https://github.com/Zilliqa/Zilliqa/blob/master/src/common/TxnStatus.h#L23 somewhere so we know what 1, 3, etc. mean.
| match errors[0] { | ||
| ScillaError::CallFailed => 11, | ||
| ScillaError::CreateFailed => 255, | ||
| ScillaError::OutOfGas => 0, |
There was a problem hiding this comment.
It seems like this should be 22? Maybe we should use an enum or at least some consts for these magic numbers and refer back to the ZQ1 source?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction status code is returned as:
As far as I can see, ZQ2 transactions and transaction receipts don't have the same information in them that the ZQ1 GetTransactionStatus API docs expect, so my approach here was to try and get as close as possible while still matching the docs, and presumably we can then later add a new API which matches ZQ2.
Closes #1551