BREAKING CHANGE: Persist node's current view in the database #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86667
changed the title
86667
force-pushed
the
1609-the-nodes-current-view-should-be-persisted-in-the-database
branch
from
3460502 to
09e102e
Compare
86667
force-pushed
the
1609-the-nodes-current-view-should-be-persisted-in-the-database
branch
from
356c2fe to
96ae581
Compare
86667
force-pushed
the
1609-the-nodes-current-view-should-be-persisted-in-the-database
branch
from
0b82176 to
83cc174
Compare
86667
force-pushed
the
1609-the-nodes-current-view-should-be-persisted-in-the-database
branch
from
83cc174 to
4dc6e3a
Compare
…n its elapsed time at startup
…s and function names to be consitent
86667
force-pushed
the
1609-the-nodes-current-view-should-be-persisted-in-the-database
branch
from
4dc6e3a to
cdef0d7
Compare
JamesHinshelwood
previously approved these changes
Nov 1, 2024
JamesHinshelwood
approved these changes
Nov 1, 2024
…ted-in-the-database
JamesHinshelwood
approved these changes
Nov 1, 2024
86667
deleted the
1609-the-nodes-current-view-should-be-persisted-in-the-database
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1609 and #1709.
For the purpose of reducing re-sync time after consensus has not been reached for a while.
For example, before these changes a node on
view: 30withfinalised_view: 10would start fromview: 10if restarted. Now, they'll start back onview :30. If enough time has passed since they went down then they will jump ahead the minimum number of views.These changes make breaking changes to the db