-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply consensus committee changes at epoch boundaries #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4385a9
to
a51c0f4
Compare
a51c0f4
to
a418267
Compare
The most important changes in this commit are in `deposit.sol`. Everything else is pretty much just supporting the new interfaces in the deposit contract. The key feature is that we now keep track of the current 'epoch' and only apply changes to the consensus committee two epochs after they are made. There are a few other changes to the deposit contract in this commit too: * The initial stakers are now passed to the contract constructor, rather than relying on the `setStake` hack. * `leader()` was removed since it isn't used anywhere and it doesn't make sense to have both `leader` and `leaderAtView`. * Delayed withdrawals are now supported - We keep a circular buffer of pending withdrawals for each validator. 2 weeks after unstaking, the validator can make another call to withdraw the funds from the deposit contract.
a418267
to
a0fc914
Compare
86667
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Couple minor comments/questions
86667
previously approved these changes
Oct 30, 2024
df5357d
to
ca9cbd9
Compare
86667
approved these changes
Oct 31, 2024
This was referenced Nov 5, 2024
shawn-zil
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important changes in this commit are in
deposit.sol
. Everything else is pretty much just supporting the new interfaces in the deposit contract. The key feature is that we now keep track of the current 'epoch' and only apply changes to the consensus committee two epochs after they are made.There are a few other changes to the deposit contract in this commit too:
setStake
hack.leader()
was removed since it isn't used anywhere and it doesn't make sense to have bothleader
andleaderAtView
.Reworked version of #1298.
Further work out of scope of this PR:
deposit.sol
.)