Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the TCP swarm with QUIC. #1585

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Replace the TCP swarm with QUIC. #1585

merged 7 commits into from
Oct 11, 2024

Conversation

shawn-zil
Copy link
Contributor

@shawn-zil shawn-zil commented Oct 8, 2024 •
edited
Loading

This PR changes the underlying swarm transport from TCP to QUIC. This is also recommended by libp2p as QUIC is faster. This has been deployed in zq2-devnet successfully. This is a breaking change and the entire network needs to be upgraded to QUIC.

JamesHinshelwood
JamesHinshelwood previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@JamesHinshelwood JamesHinshelwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as you've tested this on a real network :)

@shawn-zil shawn-zil force-pushed the 1525-quic branch 2 times, most recently from 991f29b to c7fb37b Compare October 9, 2024 03:54
@shawn-zil shawn-zil requested review from frankmeds and pavlops October 9, 2024 05:38
@shawn-zil
Copy link
Contributor Author

@frankmeds @pavlops I'd like to try switching the swarm from underlying TCP to QUIC/UDP. I'd appreciate it if you could have a look at this PR - particularly the bits that relate to deployment. Let me know if there's anything that I missed out.

Thanks!

Note: I will not merge this PR until it is successfully deployed on zq2-devnet to ensure that it works.

@shawn-zil shawn-zil changed the title Replace the TCP swarm with a QUIC swarm. Replace the TCP swarm with QUIC. Oct 11, 2024
@shawn-zil shawn-zil marked this pull request as ready for review October 11, 2024 03:11
@shawn-zil shawn-zil enabled auto-merge October 11, 2024 07:13
@shawn-zil shawn-zil requested a review from frankmeds October 11, 2024 07:13
@shawn-zil
Copy link
Contributor Author

LGTM, as long as you've tested this on a real network :)

After deploying and restarting all the nodes in zq2-devnet it seems to be running as normal. So, I think this migration from TCP to QUIC is ready for merge.

JamesHinshelwood
JamesHinshelwood approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@JamesHinshelwood JamesHinshelwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one! - We should also update the documentation to reflect this:
https://github.com/Zilliqa/dev-portal/blob/c86e875c18f6397be17c02b0344d8a715b4f23e5/zq2/docs/nodes/prototestnetnodes.md#L35

@shawn-zil shawn-zil added this pull request to the merge queue Oct 11, 2024
@shawn-zil shawn-zil mentioned this pull request Oct 11, 2024
Merged
Merged via the queue into main with commit dd2bede Oct 11, 2024
8 of 9 checks passed
@shawn-zil shawn-zil deleted the 1525-quic branch October 11, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHinshelwood JamesHinshelwood JamesHinshelwood approved these changes

@pavlops pavlops Awaiting requested review from pavlops

@frankmeds frankmeds Awaiting requested review from frankmeds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawn-zil @JamesHinshelwood @frankmeds