Store state trie in SQLite #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHinshelwood
requested review from
bzawisto,
DrZoltanFazekas and
rrw-zilliqa
JamesHinshelwood
force-pushed
the
everything-in-sql
branch
2 times, most recently
from
f93695d to
8b621e5
Compare
shawn-zil
previously approved these changes
Oct 7, 2024
JamesHinshelwood
force-pushed
the
everything-in-sql
branch
from
8b621e5 to
a878b37
Compare
shawn-zil
previously approved these changes
Oct 9, 2024
|
Does this mean that a node running with this commit will have to start from genesis/checkpoint and rebuild its state? |
|
@86667 Correct - The next release will be a breaking release anyway (https://zilliqa-team.slack.com/archives/C04D147S9QX/p1727354776586759) |
JamesHinshelwood
force-pushed
the
everything-in-sql
branch
from
a878b37 to
578d629
Compare
JamesHinshelwood
force-pushed
the
everything-in-sql
branch
from
578d629 to
eba2f36
Compare
This means that writes of blocks and writes to state can be kept in sync, because the write barriers that SQLite provides will apply to both forms of data. This should eliminate inconsistencies between the two data stores. Note that I also renamed the SQL database from `blockdata.db` to `db.sqlite3`.
JamesHinshelwood
force-pushed
the
everything-in-sql
branch
from
eba2f36 to
f1f579e
Compare
86667
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that writes of blocks and writes to state can be kept in sync, because the write barriers that SQLite provides will apply to both forms of data. This should eliminate inconsistencies between the two data stores.
Note that I also renamed the SQL database from
blockdata.dbtodb.sqlite3.