Read from init_data or contract state in scilla_read precompile #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHinshelwood
changed the title
JamesHinshelwood
force-pushed
the
scilla-read-init-data
branch
6 times, most recently
from
f7f25d6 to
e97fe35
Compare
JamesHinshelwood
changed the title
JamesHinshelwood
requested review from
bzawisto,
rrw-zilliqa and
chetan-zilliqa
JamesHinshelwood
force-pushed
the
scilla-read-init-data
branch
from
e97fe35 to
f4aaca3
Compare
rrw-zilliqa
reviewed
Sep 25, 2024
JamesHinshelwood
force-pushed
the
scilla-read-init-data
branch
from
f4aaca3 to
955856e
Compare
rrw-zilliqa
previously approved these changes
Sep 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
JamesHinshelwood
force-pushed
the
scilla-read-init-data
branch
from
955856e to
0c6d2b6
Compare
rrw-zilliqa
previously approved these changes
Sep 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
JamesHinshelwood
force-pushed
the
scilla-read-init-data
branch
from
0c6d2b6 to
20fca0d
Compare
JamesHinshelwood
force-pushed
the
scilla-read-init-data
branch
from
20fca0d to
3a89252
Compare
The scilla_read precompile now reads from either the contract state or the contract's init data when a value is queried. To achieve this, I have changed the type of a Scilla contract's `init_data` from `String` to `Vec<ParamValue>`. The same data is stored, but we now parse the data on entry so that we can retrieve values easily later.
JamesHinshelwood
force-pushed
the
scilla-read-init-data
branch
from
3a89252 to
4c36826
Compare
rrw-zilliqa
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scilla_read precompile now reads from either the contract state or the contract's init data when a value is queried.
To achieve this, I have changed the type of a Scilla contract's
init_datafromStringtoVec<ParamValue>. The same data is stored, but we now parse the data on entry so that we can retrieve values easily later.Also this fixes #1380