Fix reading Scilla maps with ByStr20 keys
#1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHinshelwood
requested review from
bzawisto,
DrZoltanFazekas and
rrw-zilliqa
Previously, the scilla_read precompile would use the EIP-55 checksummed address to look up Scilla values. However, we store Scilla values without a checksum (in lowercase), so this lookup always failed.
JamesHinshelwood
force-pushed
the
scilla-call-addr
branch
from
b7ea3a8 to
aea52d2
Compare
bzawisto
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the scilla_read precompile would use the EIP-55 checksummed address to look up Scilla values. However, we store Scilla values without a checksum (in lowercase), so this lookup always failed.