Store a block's canonicality directly in the blocks table
#1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHinshelwood
requested review from
bzawisto,
DrZoltanFazekas and
rrw-zilliqa
JamesHinshelwood
force-pushed
the
move-canonical
branch
from
e3d007a to
98ef223
Compare
3 tasks
JamesHinshelwood
force-pushed
the
move-canonical
branch
2 times, most recently
from
3052df5 to
e49aecd
Compare
One of the causes of #1056 was that we could add a block to `blocks` but not add the `number` -> `hash` mapping in `main_chain_canonical_blocks`. This meant the block existed if you looked it up via the hash or view, but didn't if looked up via its number. We could fix this by wrapping both mutations in a database operation, but I think its cleaner to just add an `is_canonical` column to `blocks`. We maintain the invariant that, for all canonical blocks, the block `number` is unique. This is easy to maintain because blocks always start as canonical and only ever become non-canonical once (i.e. a block can't become canonical again later).
JamesHinshelwood
force-pushed
the
move-canonical
branch
from
e49aecd to
c2118e0
Compare
rrw-zilliqa
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the causes of #1056 was that we could add a block to
blocksbut not add thenumber->hashmapping inmain_chain_canonical_blocks. This meant the block existed if you looked it up via the hash or view, but didn't if looked up via its number.We could fix this by wrapping both mutations in a database operation, but I think its cleaner to just add an
is_canonicalcolumn toblocks. We maintain the invariant that, for all canonical blocks, the blocknumberis unique. This is easy to maintain because blocks always start as canonical and only ever become non-canonical once (i.e. a block can't become canonical again later).